vulkan_backend is not necessarily static #10680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove STATIC keyword to make shared possible. Meanwhile, it should depend on executorch_core, not executorch
pytorch-bot
bot
added
the
module: vulkan
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10680
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit ab55446 with merge base e88aafc ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
kirklandsign
added
release notes: build
facebook-github-bot
added
the
CLA Signed
Contributor
|
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
SS-JIA
approved these changes
May 5, 2025
phaiting
pushed a commit
that referenced
this pull request
May 6, 2025
Differential Revision: D74184983 Pull Request resolved: #10680
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove STATIC keyword to make shared possible. Meanwhile, it should depend on executorch_core, not executorch
cc @SS-JIA @manuelcandales @cbilgin